Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: publish docker image #1575

Open
jkoelker opened this issue Jan 3, 2019 · 1 comment
Open

Feature: publish docker image #1575

jkoelker opened this issue Jan 3, 2019 · 1 comment

Comments

@jkoelker
Copy link

jkoelker commented Jan 3, 2019

In updating marathon-lb to use dcos-e2e, I am running minidcos in a container to minimize dependancies on the host to only docker. The dockerfile I was using (before rolling it all together into the devkit) is: https://github.com/jkoelker/marathon-lb/blob/dcos-e2e-old/Dockerfile.dcos-e2e. It's used as such:

DCOS_E2E_INSTALLERS_DIR=/abs/path/to/installers/on/host \
DCOS_E2E_WORKSPACE_DIR=/abs/path/to/workspace/on/host \
docker run --rm  --tty \
    --volume /var/run/docker.sock:/var/run/docker.sock \
    --volume ${DCOS_E2E_INSTALLERS_DIR}:${DCOS_E2E_INSTALLERS_DIR} \
    --volume ${DCOS_E2E_WORKSPACE_DIR}:${DCOS_E2E_WORKSPACE_DIR}
    dcos-e2e \
        minidcos docker create \
            --workspace-dir ${DCOS_E2E_WORKSPACE_DIR} \
            --wait-for-dcos \
            ${DCOS_E2E_INSTALLERS_DIR}/dcos_generate_config.sh

The important thing to note (at least the way I got it to work) was making the paths the same both inside and outside the container.

@adamtheturtle
Copy link
Contributor

Thank you @jkoelker - this will need a few things, at least:

  • A test which at least checks that minidcos docker --version works in Docker - see test_admin/test_brew.py and test_admin/test_binaries.py for inspiration
  • User documentation - how can I use this? why should I use this? what are the limitations?
  • A change to admin/release.py to add publishing a Docker image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants