Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening and then executing a script file encoded with UTF-8 BOM gives an error #2258

Closed
antonwierenga opened this issue Oct 3, 2017 · 3 comments
Labels
Milestone

Comments

@antonwierenga
Copy link

screen shot 2017-10-03 at 15 28 22

I am using OSX 10.12.6, DBeaver 4.2.2. Attached the script file.

test.zip

@nitram509
Copy link

Hi,

I've investigated a bit regarding this topic.
It seems to me, the root cause of this issue is kind of known ;-)
See https://www.eclipse.org/forums/index.php/t/157485/
And https://bugs.eclipse.org/bugs/show_bug.cgi?id=160614

My proposal is to follow advice and use the extension point org.eclipse.core.contenttype.contentTypes and make org.eclipse.core.runtime.text as base-type for 'sql' extensions. This should do the job.

@antonwierenga
Copy link
Author

Thanks, that seems to work. Shouldn't this be the default extension point for sql files in DBeaver?

@serge-rider serge-rider added the bug label Oct 6, 2017
@serge-rider serge-rider added this to the 4.2.3 milestone Oct 6, 2017
@serge-rider
Copy link
Member

@nitram509 thanks for the link.
Sql extension was already bound to org.eclipse.core.runtime.text but SQL content type describer was badly formed. Now fixed - BOM files are opening just fine.
See fix in 4.2.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants