Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and upload Windows target with Travis CI #6

Open
dbaelz opened this issue Oct 15, 2018 · 3 comments
Open

Build and upload Windows target with Travis CI #6

dbaelz opened this issue Oct 15, 2018 · 3 comments
Labels
CI/CD Something concerning CI/CD
Milestone

Comments

@dbaelz
Copy link
Owner

dbaelz commented Oct 15, 2018

The build of the Windows target with the (experimental) Travis CI Windows image is stalled after the tests are executed. At the moment, this target is comment out in the Travis CI script. We should analyze why the build is stalled and fix it when possible. See this comment on #3 for details.

@dbaelz dbaelz added the CI/CD Something concerning CI/CD label Oct 15, 2018
@dbaelz dbaelz added this to the Release 1.0 milestone Oct 15, 2018
@DrewCarlson
Copy link
Contributor

I managed to get Windows working with Travis for another project (see .travis.yml and a successful build).
Note that

  • --no-daemon prevents build/deploy steps from stalling
  • there is no caching because it is simply faster to download everything vs saving/loading cache archives; and
  • The jdk home must be manually defined and the installed jdk version can change between builds (hence the dir step), I don't have a good solution for this yet.

@dbaelz
Copy link
Owner Author

dbaelz commented Oct 30, 2018

I managed to get Windows working with Travis for another project (see .travis.yml and a successful build).
Sounds good. A working windows build and upload to travis ci would be great for the 1.0 release.

Note that

  • --no-daemon prevents build/deploy steps from stalling
  • there is no caching because it is simply faster to download everything vs saving/loading cache archives; and
  • The jdk home must be manually defined and the installed jdk version can change between builds (hence the dir step), I don't have a good solution for this yet.
    The absolute JDK path and the installation is really ugly, but it's a first step. We could integrate it in Konclik in this way and check in the future for a better (then working) solution.

Would you recommend that we use this solution? If so, could you implement the changes and prepare a pull request?

@DrewCarlson
Copy link
Contributor

The JDK home path is really the only issue since it will break builds when the Windows image is updated. I will open a PR when I find a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Something concerning CI/CD
Projects
None yet
Development

No branches or pull requests

2 participants