Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing checks if library is used in a wrong way? #230

Closed
klausj1 opened this issue Feb 10, 2024 · 2 comments
Closed

Missing checks if library is used in a wrong way? #230

klausj1 opened this issue Feb 10, 2024 · 2 comments

Comments

@klausj1
Copy link

klausj1 commented Feb 10, 2024

Hi,

Used library version: 2.0
Board: eps32C3 dev module

I had two issues which took me some time to find out:

  • The uniqueID of a device type must not contain a space
  • WifiClient and HAMqtt must be defined in the code before the entities are defined

I did not see an error message, it just did not work.

I am not sure if there are error messages already, because I did not manage to change the "Core Debug Level:" in the board configuration - I never saw any message, also not from other libraries.

If you are interested, I can also provide a more detailed description.

@dawidchyrzynski
Copy link
Owner

Hi @klausj1,

I will consider adding additional checks, possibly enabled by a macro; however, I am not fan of allocating resources (RAM/flash) for such scenarios. My general recommendation is to thoroughly review the documentation, as it describes your findings.

https://dawidchyrzynski.github.io/arduino-home-assistant/documents/library/introduction.html
https://dawidchyrzynski.github.io/arduino-home-assistant/documents/library/compiler-macros.html

@klausj1
Copy link
Author

klausj1 commented Feb 11, 2024

OK, Thx. Feel free to close this issue ;)

@dawidchyrzynski dawidchyrzynski closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants