Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empirical risk level sets when design matrix not full rank #72

Open
davidrosenberg opened this issue Jan 14, 2019 · 2 comments
Open

Empirical risk level sets when design matrix not full rank #72

davidrosenberg opened this issue Jan 14, 2019 · 2 comments

Comments

@davidrosenberg
Copy link
Owner

In lectures and homework on describing the level sets of empirical risk for linear least squares models, we are not careful about the case that the design matrix is not full rank. This case is ignored here:
https://davidrosenberg.github.io/mlcourse/Archive/2018/Lectures/03a.elastic-net.pdf#page=14
And explicitly mentioned here:
https://davidrosenberg.github.io/mlcourse/Archive/2018/Lectures/02c.L1L2-regularization.pdf#page=25
But without any justification for the claim.
Perhaps we can put caveats in the slides, and have students work it out as an optional problem in the ellipsoids homework problem:
https://davidrosenberg.github.io/mlcourse/Archive/2018/Homework/hw2.pdf#page=9
Or just make a note about it and post.

@davidrosenberg davidrosenberg changed the title Need more careful treatment empirical risk level sets when design matrix not full rank Empirical risk level sets when design matrix not full rank Jan 14, 2019
@brett1479
Copy link
Collaborator

That homework problem seems to either be incorrect or missing something. The full rank assumption has to come at the beginning so that (X^TX)^{-1} makes sense. Without the full rank assumption you get an ellipsoid in the row space summed with the null space (so an elliptical cylinder?).

@davidrosenberg
Copy link
Owner Author

Yeah definitely should have the full rank condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants