Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't work in UTF-8 locales #1

Open
ian-abbott opened this issue Nov 11, 2015 · 1 comment · May be fixed by #2
Open

Doesn't work in UTF-8 locales #1

ian-abbott opened this issue Nov 11, 2015 · 1 comment · May be fixed by #2

Comments

@ian-abbott
Copy link

The calls to grep in the script do not find the byte sequences in a UTF-8 locale as the zImage file gets treated as a text file in the current locale. A workaround is to run the script in the C (or POSIX) locale. A fix is to prepend LANG=C to the grep commands in the script.
@davidmroth
Copy link
Owner

Thank you for the feedback @ian-abbott! If you have a suggestion on how to incorporate this fix, please provide it via a pull request, or replying to this thread with a patch.

Best Regards,
David Roth

shizmob added a commit to shizmob/Extract-Kernel-Initramfs that referenced this issue May 15, 2017
@shizmob
Fix failure in UTF-8 locales
6977324 
This fixes davidmroth#1: detection failures of the gzip image in UTF-8 locales because of grep treating high bytes (MSB set) differently.
@shizmob shizmob linked a pull request May 15, 2017 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix failure in UTF-8 locales shizmob/Extract-Kernel-Initramfs
2 participants
@davidmroth @ian-abbott