Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate get_spaces in favour of direct access to namespaces mapping proxy #7

Open
davidesarra opened this issue Jun 19, 2020 · 0 comments

Comments

@davidesarra
Copy link
Owner

At the moment get_spaces returns a proxy map of space names and Space instances, which offer two attributes, name and namespace.

As part of a rewrite to make the magics of this package reflect the expected behaviour of the IPython console, the Space class will probably cease to have the current role.

This issue proposes to:

  • Deprecate get_spaces raising a warning

  • Add a proxy map space names and namespace dicts as jupyter_spaces.spaces

    from jupyter_spaces import namespaces
    
    namespace = namespaces["space_name"]
    namespace["reference_name"]

    The the keys of namespaces will be exactly equivalent toSpace.namespace, whose behaviour is described in the README.

  • Remove get_spaces after some time

@davidesarra davidesarra changed the title Deprecate get_spaces in favour a proxy map of space names and namespace dicts Deprecate get_spaces in favour of direct access to namespaces mapping proxy Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant