add configuration options for bitwarden role #445
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PurpleNinja225
added a commit
to PurpleNinja225/NASible
that referenced
this pull request
Mar 27, 2021
|
This PR has a few things mashed in together - the bug fixes and functionality I'd like to get merged, but also my comments as per #446 apply here to, which i'm not happy merging at this point in time. If you can separate (per contribution guidelines :-)) we can get this one merged asap. |
configure DOMAIN for U2F
d-rk
force-pushed
the
feature/bitwarden_mod
branch
from
639f75b
to
a20686b
Compare
|
@davestephens I separated it into two PRs and removed the configuration options for the docker images |
|
bitwarden_allow_signups: false needs quotes around "false" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes #430