Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In xcode 6 beta4 building shows a couple of warnings #67

Open
philosopherdog opened this issue Aug 4, 2014 · 12 comments
Open

In xcode 6 beta4 building shows a couple of warnings #67

philosopherdog opened this issue Aug 4, 2014 · 12 comments
Labels

Comments

@philosopherdog
Copy link

  1. CHCSVParser.m:862:1: Designated initializer missing a 'super' call to a designated initializer of the super class
  2. CHCSVParser.m:863:18: Designated initializer should only invoke a designated initializer on 'super'
@edwardmp
Copy link

I noticed this too in Xcode 6 and I've fixed it in my fork and created a pull request.
See #68

@philosopherdog
Copy link
Author

Hopefully it gets merged in!

@edwardmp
Copy link

I hope so too, but the warnings are pretty harmless but nonetheless annoying.

@rhummelmose
Copy link

Yeh, please merge this. Quite an aggressive warning by X-Code though.

@yoasha
Copy link

yoasha commented Nov 28, 2014

Not a big issue.. but I would love to see it fixed!

@jomnius
Copy link

jomnius commented Dec 12, 2014

Bumb. I believe in zero-warnings code policy.

@philosopherdog
Copy link
Author

I'm just looking this problem over again. The issue is that - (instancetype)initWithObjects:(const id [])objects forKeys:(const id [])keys count:(NSUInteger)cnt is the designated initializer in the superclass and this subclass overrides this method and calls an overridden convenience initializer from this overridden designated initializer. So, we've switched the designated initializer from that found in the superclass to the subclass. I'm not entirely sure how to solve this, but one workaround is to override this method with an NSAssert to prevent it from being called directly from CHCSVParser. You could just comment out this overridden designated initializer but then I suppose it's possible that somebody could call this method from CHCSVParser and generate an unexpected result. Please let me know your thoughts, if that seems like a reasonable approach I'll do a pull request with the solution.

@edwardmp
Copy link

I am no longer seeing warnings in Xcode 6, so I guess this issue can be closed @davedelong.

@philosopherdog
Copy link
Author

I'm still seeing it in the release version of Xcode 6.

@edwardmp
Copy link

You are right; my dependency manager still used my own fixed branch. It seems @davedelong has implemented a fix, however CocoaPods.spec is still set to the tag 2.1.0 of July 2014 so any commits after that are not included. If @davedelong would release a new tag, the warnings would disappear.

@edwardmp
Copy link

As a workaround you could temporarily use this in your Podfile:
pod 'CHCSVParser', :git => 'https://github.com/davedelong/CHCSVParser.git'

This just uses the master branch instead of tags

@philosopherdog
Copy link
Author

Ok, cool. @edwardmp thanx for the info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants