Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] -password option in sript mode #1273

Open
2 tasks done
hxss opened this issue Feb 14, 2021 · 15 comments
Open
2 tasks done

[REQUEST] -password option in sript mode #1273

hxss opened this issue Feb 14, 2021 · 15 comments

Comments

@hxss
Copy link

hxss commented Feb 14, 2021

Before creating a feature request

  • I checked the next branch to see if the feature has already been
    implemented

  • I searched existing reports to see if it is already requested.

What is the user problem or growth opportunity you want to see solved?

Please add support of -password option(and other useful options) in script mode.

How do you know that this problem exists today? Why is this important?

The following cases not hides user input:

  • command:
rofi -password -modi client:"./test.py --client" -show client
  • script extra-option '\0password\n'.

Who will benefit from it?

The world.

Version

1.6.1

Configuration

Default configuration

@hxss
Copy link
Author

hxss commented Feb 21, 2021

It seems like no-custom also doesn't work in script mode. I tried \0no-custom\x1f\n and \0no-custom\n - my client script always receives custom input from rofi.

@DaveDavenport
Copy link
Collaborator

Please follow the guidelines! f.e. do not report unrelated bugs/issues onto other issues.

@hxss
Copy link
Author

hxss commented Nov 20, 2021

@DaveDavenport hello! Is there any plans to add the future in the near future?

@DaveDavenport
Copy link
Collaborator

no, given you can have multiple modi enabled and switch between them, there is no point to this. Either the pasword becomes visible when switching between modi, or you cannot see what you enter when you include this mode.

@hxss
Copy link
Author

hxss commented Nov 20, 2021

As a developer, I only set the script mode for the rofi session, so the user cannot switch modes in my window.

@DaveDavenport
Copy link
Collaborator

I am not sure how that is relevant for a generic feature?

@DaveDavenport
Copy link
Collaborator

(A mode imho is a standalone thing that a user adds to his list of modi. How it is going to be called and combined with other modi is up to the user, not the developer).

@hxss
Copy link
Author

hxss commented Nov 20, 2021

The server of my application starts rofi as rofi -modi client: <client> -show client. The client then asks the server for lists to show the user in rofi and at one point I need to set \0password\x1ftrue\n to hide the user input. Rofi runs by my app, not by user.

@DaveDavenport
Copy link
Collaborator

DaveDavenport commented Nov 20, 2021

So it is not a mode at all? Why not use dmenu emulation that is more targeted at this use?

@hxss
Copy link
Author

hxss commented Nov 20, 2021

Because the script mode avoids flickering between the display of rofi windows

@RaZ0rr-Two
Copy link
Contributor

dmenu has a patch to hide password

@DaveDavenport
Copy link
Collaborator

@RaZ0rr-Two not sure what you are trying to say? rofi dmenu emulation also has a option to hide the password.

@RaZ0rr-Two
Copy link
Contributor

Oh, my bad. I thought op was asking for an option to add hide password option. Didn't know it already came with it. All good

@Ghibranalj
Copy link

Any update on this feature?. I would be really nice. Im trying to make a network manager UI. And i find rofi-dmenu to be a bit janky (since it flickers when the script is blocking), and rofi-script is easier to write than dmenu

@DaveDavenport
Copy link
Collaborator

DaveDavenport commented Aug 16, 2022

No. If there was an update, this issue would have mentioned it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants