Optimize highlights using global highlight group cache #108
Conversation
Instead of creating all highlight groups, the commands for them are generated and cached in a global variable. While rendering statusline and tabline, the highlight groups used are created on demand.
|
Although the number of highlight groups reduced, no noticeable performance improvement was seen on large files. So, number of highlights was not the bottleneck. Will work on improving performance. |
|
Question, is this ready to be merged? Fun fact, I cannot test this plugin using the classic |
|
This solves the number of highlights issue. Performance improvement still needs to be worked on. Other than that, this is ready to be merged. |
There was a problem hiding this comment.
Seems to work properly in my computer.
I used this command to test the plugin (fun fact: I just needed to add set termguicolors to test the pull request without merging):
nvim --clean \
--cmd "set rtp+=." \
--cmd "source plugin/bubbly.vim" \
--cmd "source test-configuration.lua"The contents of test-configuration.lua were:
vim.opt.termguicolors = true
vim.g.bubbly_palette = {
background = "#34343c",
foreground = "#c5cdd9",
black = "#3e4249",
red = "#ec7279",
green = "#a0c980",
yellow = "#deb974",
blue = "#6cb6eb",
purple = "#d38aea",
cyan = "#5dbbc1",
white = "#c5cdd9",
lightgrey = "#57595e",
darkgrey = "#404247",
}
vim.g.bubbly_statusline = {
'mode',
'truncate',
'path',
'divisor',
'filetype',
'progress',
}
|
I will now merge into I am thinking about refining this process, maybe using conventional commits and squashing the pull request. |
Instead of creating all highlight groups, the commands for them are generated and cached in a global variable. While rendering statusline and tabline, the highlight groups used are created on demand.
Fixes #104.