Datoviz expects to be top level CMake project

[wolro]

Hello Cyril,

First: as a VisPy user looking to include a performant visualization library into a non-Python project, Datoviz looks like an absolute godsend!

Note that I am using MinGW on a Windows 10 system.

Trying various ways to include Datoviz as a dependency into another (CMake) project, I ran into the issue that the CMakeLists.txt file uses the "${CMAKE_SOURCE_DIR}" / "${CMAKE_BINARY_DIR}" variables. While this is no issue when precompiling and adding Datoviz as a shared library, it prevents smooth adding of the library via e.g.:

add_subdirectory(libs/datoviz)

Trying this, one currently has to add the "cmake", "data" and "external" folders as well as "include/datoviz" to the top-level folder referenced by ${CMAKE_SOURCE_DIR}. Upon quick testing, simply replacing the two variables by ${PROJECT_SOURCE_DIR}" and ${PROJECT_BINARY_DIR} resolved this, and a test project adding Datoviz via "add_subdirectory" worked just fine.

I suspect that with this change, also simply pulling in Datoviz via "FetchContent_Declare / FetchContent_MakeAvailable" might just work; trying this, currently one runs into similar issues as with "add_subdirectory" which can also be resolved by adding the respective folders to top level, but then I ran into ODR violation issues with ImGui involving standard and GLFW headers.

In any case thank you for the great work, and kind regards!
Wolfgang

[rossant]

Hi Wolfgang, thank you for raising this issue. Would you consider submitting a pull request to fix this? I'll quickly test it and merge if it works for me!

[wolro]

Hi Cyril, sure! Submitted the pull request. Hope it doesn't break anything on other platforms than Windows / MinGW.