Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing Versions Info causes the order in which they are listed to change when using filesystem backend #30

Open
pdelboca opened this issue Jul 15, 2020 · 2 comments

Comments

@pdelboca
Copy link
Collaborator

This may be as well an issue in metastore-lib but I'm not sure if this is something we need to adress on the UX level or in the backend. When editing a Version the order in which they are displayed changes making it confusing to know which version is the first and which one is the last.

Steps to Reproduce:

  • Create a dataset and add a few versions.
  • Edit the name of one of the Versions (second version in this example) and save it
  • The versions are no longer shown in the same order

As far as I tested, this is not happening when using a github backend. Even so, it would be nice to the behaviour of both backends to be the same.

@rufuspollock
Copy link
Member

@pdelboca good bug find.

As an aside can we consistently use RevisionTag (or Release if you want a nicer word) at least internally (i saw title and was not sure what this was about).

@shevron
Copy link
Contributor

shevron commented Jul 16, 2020

This should be reported in metastore-lib, in any case good catch. We need to find the expected behavior of tag_list - is it sort by creation time or alphabetically, and if creation time should it be newest first or oldest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants