Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling mistake #122

Open
d3ac opened this issue Jan 4, 2023 · 1 comment
Open

Spelling mistake #122

d3ac opened this issue Jan 4, 2023 · 1 comment

Comments

@d3ac
Copy link

d3ac commented Jan 4, 2023

There is a spelling mistake in the code "MonteCarlo.ipynb" (class "FisrtVisitMC" -> "FirstVisitMC").

@d3ac
Copy link
Author

d3ac commented Jan 4, 2023

Thanks for your code. I have a little suggestion : move "agent.update(one_ep_transition)" out of the loop, then it will be at least 60 times faster than before. In practice, I think there is no need to update agent in the loop since it will bring high time complexity ($O(n^2)$). As I tried, I got a obvious better convergence value and faster speed. I wonder if it is feasible. I would appreciate it if you could solve my problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant