Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] Build: Unable to build gravitino in Linux environment due to JAVA problem #3336

Closed
rich7420 opened this issue May 11, 2024 · 9 comments · Fixed by #3538
Closed

[Bug report] Build: Unable to build gravitino in Linux environment due to JAVA problem #3336

rich7420 opened this issue May 11, 2024 · 9 comments · Fixed by #3538
Assignees
@mchades
Labels
0.5.1 Release v0.5.1 0.6.0 Release v0.6.0 bug Something isn't working

Comments

@rich7420
Copy link

Version

main branch

Describe what's wrong

When I use "./ gradlew build" to build environment. There are some failed test. My OS is Ubuntu 22.04.4 and openJDK is 11.0.22.
By the way, the command "./gradlew build -x test" has all successful test.
image

Error message and/or stacktrace

image
image
image

How to reproduce

Please see Above. Thanks

Additional context

OS：Linux gravitino 6.5.0-28-generic #29~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Thu Apr 4 14:39:20 UTC 2 x86_64 x86_64 x86_64 GNU/Linux
JAVA：
openjdk 11.0.22 2024-01-16
OpenJDK Runtime Environment (build 11.0.22+7-post-Ubuntu-0ubuntu222.04.1)
OpenJDK 64-Bit Server VM (build 11.0.22+7-post-Ubuntu-0ubuntu222.04.1, mixed mode, sharing)
@rich7420 rich7420 added the bug Something isn't working label May 11, 2024
@xunliu
Copy link
Collaborator

xunliu commented May 11, 2024

hi @rich7420 Thanks you for report this issue.
@danhuawang Please look bug?

@mchades
Copy link
Contributor

mchades commented May 11, 2024

Could you please follow the how-to-test doc and have a try?

@yuqi1129
Copy link
Contributor

yuqi1129 commented May 11, 2024 •
edited

I can't reproduce it locally with Linux Linux ubuntu-intel 6.7.10-orbstack-00140-g04c64cb35a2e #1 04:39:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux, maybe I need ubuntu 22.0.4 image.

@rich7420
Copy link
Author

rich7420 commented May 12, 2024 •
edited

Could you please follow the how-to-test doc and have a try?

I've tried
./gradlew test -PskipITs
and

./gradlew build -x test

In the duplicate Virtual Box, There is their message.
./gradlew test -PskipITs
image

./gradlew build -x test
image

@jerryshao
Copy link
Collaborator

It seems like Junit has some issues?

@yuqi1129
Copy link
Contributor

This seems to be introduced by #3197, I tried but can't reproduce it locally in the orback virtual machine.

@jerryshao
Copy link
Collaborator

I don't see any valuable information in the above description. How do you know that it is due to #3197?

@yuqi1129
Copy link
Contributor

image

The error stacks contain class com.datastrato.gravitino.integration.test.util.CloseContainerExtension. The final outcome may not be entirely accurate, all I can say is that it's just my guess.

@mchades mchades mentioned this issue May 23, 2024
Merged
@mchades
Copy link
Contributor

mchades commented May 23, 2024

@rich7420
I have reproduced this issue locally, possibly because you did not start the docker server before working on IT.

You can try pulling PR #3538 and running it again to see a clearer error message.

jerryshao pushed a commit that referenced this issue May 24, 2024
@mchades
[#3336] improvement(test): make docker detection failure error messag…
0301c3f 
…es more clear (#3538)

### What changes were proposed in this pull request?

 - clarify OrbStack status
 - check the docker env before IT start

### Why are the changes needed?

The previous detection logic was located in the constructor, and when
the test failed, it would throw an exception
`ExceptionInInitializerError`, causing the original error to be covered.

Fix: #3336 

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

Locally, by hand
github-actions bot pushed a commit that referenced this issue May 24, 2024
@mchades @web-flow
[#3336] improvement(test): make docker detection failure error messag…
f5478ee 
…es more clear (#3538)

### What changes were proposed in this pull request?

 - clarify OrbStack status
 - check the docker env before IT start

### Why are the changes needed?

The previous detection logic was located in the constructor, and when
the test failed, it would throw an exception
`ExceptionInInitializerError`, causing the original error to be covered.

Fix: #3336 

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

Locally, by hand
@jerryshao jerryshao mentioned this issue May 24, 2024
Merged
@jerryshao jerryshao added 0.5.1 Release v0.5.1 0.6.0 Release v0.6.0 labels May 24, 2024
mchades added a commit that referenced this issue May 24, 2024
@jerryshao @mchades
[#3336] improvement(test): make docker detection failure error messag…
988560f 
…es more clear (#3542)

### What changes were proposed in this pull request?

 - clarify OrbStack status
 - check the docker env before IT start

### Why are the changes needed?

The previous detection logic was located in the constructor, and when
the test failed, it would throw an exception
`ExceptionInInitializerError`, causing the original error to be covered.

Fix: #3336 

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

Locally, by hand

Co-authored-by: mchades <liminghuang@datastrato.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mchades mchades

Labels
0.5.1 Release v0.5.1 0.6.0 Release v0.6.0 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#3336] improvement(test): make docker detection failure error messages more clear mchades/gravitino
5 participants
@jerryshao @xunliu @yuqi1129 @mchades @rich7420