Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3326] feat(jdbc-doris): output the alter status of table into the log #3332

Merged
merged 1 commit into from May 13, 2024
Merged

[#3326] feat(jdbc-doris): output the alter status of table into the log #3332

merged 1 commit into from May 13, 2024

Conversation

zhoukangcn
Copy link
Contributor

@zhoukangcn zhoukangcn commented May 10, 2024 •
edited

What changes were proposed in this pull request?

Output the alter status of table into the log

Why are the changes needed?

Fix: #3326

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

Manual, check log

@zhoukangcn zhoukangcn changed the title [#3326] feat(jdbc-doris): show table alter status in log [#3326] feat(jdbc-doris): output the alter status of table into the log May 11, 2024
yuqi1129
yuqi1129 reviewed May 11, 2024
View reviewed changes
...ris/src/main/java/com/datastrato/gravitino/catalog/doris/operation/DorisTableOperations.java Outdated
// sql is `SHOW ALTER TABLE COLUMN WHERE TableName = 'test_table'`
// database name must be specified in connection, so the SQL do not need to specify database
// name
String sql = String.format("SHOW ALTER TABLE COLUMN WHERE TableName = '%s' limit 1", tableName);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can alter table operation be executed in serialization?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NO, as metioned in https://doris.apache.org/docs/1.2/advanced/alter-table/schema-change/

Because the Schema Chanage job is an asynchronous operation, only one Schema chanage job can be performed on the same table at the same time. To check the operation status of the job, you can use the following command

@yuqi1129 yuqi1129 added the upload log Always upload container log label May 11, 2024
@yuqi1129 yuqi1129 closed this May 11, 2024
@yuqi1129 yuqi1129 reopened this May 11, 2024
yuqi1129
yuqi1129 approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@yuqi1129 yuqi1129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuqi1129 yuqi1129 added branch-0.5 need backport Issues that need to backport to another branch and removed upload log Always upload container log labels May 13, 2024
@yuqi1129 yuqi1129 merged commit 6f2dba2 into datastrato:main May 13, 2024
47 checks passed
github-actions bot pushed a commit that referenced this pull request May 13, 2024
@zhoukangcn @web-flow
[#3326] feat(jdbc-doris): output the alter status of table into the l…
7f08e75 
…og (#3332)

### What changes were proposed in this pull request?

Output the alter status of table into the log

### Why are the changes needed?

Fix: #3326

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

Manual, check log
@zhoukangcn zhoukangcn deleted the f-3326 branch May 13, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuqi1129 yuqi1129 yuqi1129 approved these changes

Assignees

@zhoukangcn zhoukangcn

Labels
branch-0.5 need backport Issues that need to backport to another branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement] output the alter status of table into the log
2 participants
@zhoukangcn @yuqi1129