New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] revisit all the dropXXX interfaces to have a consistent behavior #2434
Comments
if succ, return true, if not exists return false, otherwise, throw corresponding exception, the behavior seems clear. |
I think we should revisit all the drop related APIs and implementations, and change the behavior if necessary, which includes:
|
I would love to revisit all the drop related APIs and implementations first, then write the results into a document. |
Great, you can go ahead. Thanks a lot. |
Is this a list of all Rest APIs? |
Yep, you can also look into the codes in package The web also FYI: https://datastrato.ai/docs/0.4.0/api/rest/gravitino-rest-api |
@mchades @FANNG1 @yuqi1129 @diqiu50 @jerryshao @mchades |
Could you please also add the exception response? For example, the response when encountering a RuntimeException.
yep, it's WIP #2492 BTW, it's better to make your doc commentable |
The exception response has been updated, but it seems that the implementation is not aligned. |
@charliecheng630 are you still working on this? I found that for most the JDBC catalogs, the current implementation is not aligned the definition, we should improve it. |
@jerryshao I haven't started to work yet. I will work on this ASAP. |
OK, thanks! |
@mchades After tracing code, here are the areas that need to be improve:
Please correct me if I am wrong. |
I'm working on the core part to fix the current fix, you can check #3075 and the related PR. I think what you should check is:
|
I've check all the Operation Dispatcher's dropXXX in #3075. |
What would you like to be improved?
we should revisit all the dropXXX interfaces:
a) We should define a clear behavior of return value (false) and exception thrown.
b) We should have a consistent behavior for all the dropXXX interfaces.
How should we improve?
No response
Subtasks
The text was updated successfully, but these errors were encountered: