Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more module testing and upgrade to pytest #166

Merged
merged 23 commits into from Jul 27, 2020
Merged

Add more module testing and upgrade to pytest #166

merged 23 commits into from Jul 27, 2020

Conversation

sdhutchins
Copy link
Member

Fixes issue #25

Changes proposed in this pull request:

  • Migrate from nosetests to pytest since nose is no longer maintained.
  • Add additional module tests.

@sdhutchins sdhutchins requested a review from grabear July 24, 2020 18:52
@sdhutchins sdhutchins linked an issue Jul 24, 2020 that may be closed by this pull request
Module Testing #25
Open
20 tasks
@sdhutchins sdhutchins changed the base branch from master to dev-master July 24, 2020 18:52
@sdhutchins sdhutchins self-assigned this Jul 24, 2020
grabear
grabear approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@grabear grabear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

grabear
grabear previously approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@grabear grabear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sdhutchins sdhutchins changed the title WIP Add more module testing and upgrade to pytest Add more module testing and upgrade to pytest Jul 26, 2020
@sdhutchins sdhutchins requested a review from grabear July 26, 2020 21:29
@sdhutchins sdhutchins dismissed grabear’s stale review July 27, 2020 17:15

Added new commits.

grabear
grabear approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@grabear grabear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sdhutchins
Copy link
Member Author

👍

You're fast! lol

@sdhutchins sdhutchins merged commit 423e28b into dev-master Jul 27, 2020
@sdhutchins sdhutchins deleted the issue-25 branch July 27, 2020 17:17
@grabear
Copy link
Member

grabear commented Jul 27, 2020

👍

You're fast! lol
lol. I just happened to be on GitHub at the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grabear grabear grabear approved these changes

Assignees

@sdhutchins sdhutchins

Labels
👍 Status: Accepted 👍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module Testing
2 participants
@sdhutchins @grabear