Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

useas: configmap may result in invalid bash variable names #285

Open
starpit opened this issue Jul 26, 2023 · 0 comments
Open

useas: configmap may result in invalid bash variable names #285

starpit opened this issue Jul 26, 2023 · 0 comments

Comments

@starpit
Copy link

starpit commented Jul 26, 2023

e.g. if my dataset is test7-data, then you generate env vars like test7-data_bucket, which is not a valid bash variable name. 馃

i'm not sure quite what the best fix is here. maybe changing dashes and any other invalid bash variable names to underscore? i think the valid character class is [a-zA-z0-9_]+, and to be safe, perhaps avoid starting with a digit, [a-zA-Z_][a-zA-Z0-9_]*. i think this is known as a C_IDENTIFIER.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant