Intermitted expressions failures during testing

[bodiam]

Describe the bug

It seems there's another or new bug in our tests:

 10:28:42.078 [ERROR] Failures: 
10:28:42.078 [ERROR] net.datafaker.providers.base.RestaurantTest.name
10:28:42.078 [ERROR]   Run 18: RestaurantTest.name:33 
Expecting actual:
  "## Bakery"
not to contain:
  ["#", "?"]
but found:
  ["#"]

A clear and concise description of what the bug is.

To Reproduce

I cannot.

Expected behavior

The test should pass

Versions:

• Faker Version 2.2.x-snapshot

[bodiam]

See: https://github.com/datafaker-net/datafaker/actions/runs/8983777400/job/24674231666

[bodiam]

@snuyanzin Do you have any idea which part of the code can cause this? Is this related to the COW map, or some other part of the code? It seems are tests are failing more and more, but I'm not entirely sure where to look, plus it seems quite random. If you have a pointer on where to look, that would be greatly appreciated!

[snuyanzin]

That looks strange, it looks like sometimes it doesn't take into account possible expressions inside values.
I'm not sure whether it is COW, currently it doesn't look like that

[bodiam]

I've ran the test locally quite a few times, and I'm not able to reproduce it, but I will have some time over the weekend to look into this.

[snuyanzin]

If I'm not mistaken @RVRhub is also looking at it, please correct me if I'm wrong

[RVRhub]

Yes, I started looking into this problem.
I have determined that this is because sometimes resolveExpression uses a Supplier that retrieves data from a file.

[snuyanzin]

@bodiam it might happen that @RVRhub has fixed it within #1198 (not 100%)
however now it looks much more stable, so if you know how to reproduce it would worth to check it against the latest main

[bodiam]

@snuyanzin no idea how to reproduce it, I just know it happens sometimes. Let's monitor it for a week or so, and then close this issue if it's fixed.