Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot update nexus_security_ldap resource #82

Closed
Skaronator opened this issue Aug 25, 2020 · 5 comments · Fixed by #112
Closed

Cannot update nexus_security_ldap resource #82

Skaronator opened this issue Aug 25, 2020 · 5 comments · Fixed by #112
Assignees
Labels
bug Something isn't working

Comments

@Skaronator
Copy link

Skaronator commented Aug 25, 2020

I'm trying to update a parameter on a newly created nexus_security_ldap resources but get the following error:

Error: could not update LDAP server `My AD`: HTTP: 400, :[ {
  "id" : "PARAMETER id",
  "message" : "may not be empty"
} ]

I've only changed the connection_retry_delay_seconds from 1 to 2 to reproduce this bug. My Terraform Plan looks like this:

# nexus_security_ldap.this will be updated in-place
  ~ resource "nexus_security_ldap" "this" {
        auth_password                  = (sensitive value)
        auth_realm                     = "LOCAL"
        auth_schema                    = "SIMPLE"
        auth_username                  = "NexusAD"
      ~ connection_retry_delay_seconds = 1 -> 2
        connection_timeout_seconds     = 1
        group_base_dn                  = "OU=Groups"
        group_id_attribute             = "sAMAccountName"
        (.... more keys removed....)
    }

Terraform Version: 0.13.0
Provider Version 1.10.2
Nexus Version: 3.25.1


More findings:

  • The whitespace in the name is not a problem, same issue without whitespace
  • I also see there is already code that sends the ID to the nexus package correctly
    ldapID := d.Id()
    ldap := getSecurityLDAPFromResourceData(d)
    if err := client.LDAPUpdate(ldapID, ldap); err != nil {
    return err
    }
  • "id" attribute exist in my terraform state file but is NOT the same as in nexus? When clicking on the LDAP setting I'll get routed to "/#admin/security/ldap:d0d442e3-01f5-4354-a588-9e119ad1b0d6" and maybe "d0d442e3-01f5-4354-a588-9e119ad1b0d6" is the ID? Not sure.
@anmoel anmoel self-assigned this Jan 20, 2021
@anmoel
Copy link
Member

anmoel commented Jan 20, 2021

Hi @Skaronator,

tanks for your report and sorry for our delayed reply.
I will check the issue in the next few weeks.

regards
André

@anmoel anmoel added this to Needs triage in Ticket tracker Jan 21, 2021
@anmoel anmoel moved this from Needs triage to High priority in Ticket tracker Jan 21, 2021
@anmoel anmoel added the bug Something isn't working label Jan 21, 2021
Ticket tracker automation moved this from High priority to Closed Aug 13, 2021
@anmoel
Copy link
Member

anmoel commented Aug 13, 2021

@Skaronator

please test with vesion v1.13.1 and reopen again if needed

@Skaronator
Copy link
Author

Thanks for fixing! :)

@anmoel
Copy link
Member

anmoel commented Aug 13, 2021

@Skaronator
sry for the huge delay. we will increase our development time for this provider in the next time

@Skaronator
Copy link
Author

No worries. It's great that you guys dedicate time in a open source free product.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants