Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct handling of jam values in median approximation #17

Open
sastoudt opened this issue Jul 30, 2019 · 4 comments
Open

Correct handling of jam values in median approximation #17

sastoudt opened this issue Jul 30, 2019 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@sastoudt
Copy link
Contributor

Thanks to some clarification from our Census friends:

The jam value represents a result from a median calculation when the median can't actually be calculated because it lies in the lowest or highest bin. The jam value is not used in the median calculation itself as a lower or upper bound for the end bins.

This information doesn't impact the calculations of the examples we have now (we've treated the jam value as a bound), but we need to update the median function to handle the scenario where the lower and upper bins don't have concrete bounds (plus add examples of this scenario).

We may want to include an optional input jam_value to use in the case that the median occurs in the highest/lowest bin.

@sastoudt
Copy link
Contributor Author

sastoudt commented Aug 1, 2019

proof of concept here

@sandhya-k sandhya-k added the help wanted Extra attention is needed label Aug 6, 2019
@sandhya-k sandhya-k added this to the Minimum pipeline milestone Aug 6, 2019
@palewire
Copy link
Collaborator

palewire commented Aug 8, 2019

I think that goes right here

@palewire
Copy link
Collaborator

palewire commented Aug 8, 2019

Might be good to throw a warning when this happens too.

@palewire palewire changed the title interpretation of jam values Correct handling of jam values in median approximation Aug 8, 2019
@sastoudt
Copy link
Contributor Author

dealt with in #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants