Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User story #3 #7

Open
FrancesMadden opened this issue Jul 3, 2020 · 1 comment
Open

User story #3 #7

FrancesMadden opened this issue Jul 3, 2020 · 1 comment

Comments

@FrancesMadden
Copy link

A few comments on this user story from a documentation perspective.

Define and Run GraphQL query - I don't think it's specified that the query on University of Oxford is being run based on its ROR ID except that the hyperlink resolves to the ROR record.

I think the instructions on how to use the vega editor could have a few extra points to avoid losing people. Mentioning opening the .txt files in a new tab (binder doesn't default to this and then you have reload the binder page) and paste them in overwriting the default text on the left side of the editor. I was viewing the vega editor using a mac and it I had to use arrows to scroll up and down but I don’t think that's an issue.

I think the overlay text on the diagrams is excellent - really clear and illustrative.

datasome pushed a commit that referenced this issue Jul 5, 2020
@datasome
Copy link

datasome commented Jul 5, 2020

@FrancesMadden - glad you liked the overlays and thanks for the comments - have just pushed a fix to address them. Please let me know of any further issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants