New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial feedback user story 10 - grant outputs #1
Comments
@mfenner, I have addressed all the issues - please see below:
|
@datasome Looks good. The chord diagram came out really nice. Maybe a few small changes will improve it:
I think the bar chart outputs over time can be improved. I would include every month from project start December 2017 until project end November 2020, not just months with outputs. |
@mfenner, I have done the following to address the above feedback:
Please note that I have not sorted creator names by FREYA partner affiliation as GraphQL query does not return affiliations currently. Will revise once creator affiliations can be retrieved. |
@mfenner, I have now addressed the following comments from today's meeting:
|
@mfenner, I've added a fix to display the chord plot in mybinder.org - following the work-around suggested in https://github.com/shahinrostami/chord/issues/1. This actually writes out the plot's html to the server and then displays that html inside the notebook. The fix also works in JupyterLab. |
@mfenner, I have now documented in Markdown the notebook for user story 10. Please note that the top Markdown table appears borderless in Jupyter lab and mybinder.org, but somehow not in github. |
In this initial feedback I want to focus on the GraphQL used, and potential improvements.
use
types { resourceType }
to have a more specific description of the outputs, e.g.Presentation
orProject deliverable
.dates { date dateType }
to have more specific publication dates, enabling a bar graph that is by month and not by yearformattedCitation(style: "vancouver")
instead ofbibtex
to format the metadata into a human readable format. This assumes that the notebook generates a nicely formatted document rather than a bibtex file to download (we could do that in another notebook).The text was updated successfully, but these errors were encountered: