Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First challenge in the raster structure lesson is incorrect #310

Open
jsta opened this issue Feb 18, 2020 · 2 comments
Open

First challenge in the raster structure lesson is incorrect #310

jsta opened this issue Feb 18, 2020 · 2 comments

Comments

@jsta
Copy link
Member

jsta commented Feb 18, 2020

We cannot tell the units of our elevation data from the crs. Rather, the crs tells us the x and y units but not the z (elevation) units.

@HeatherSavoy-USDA
Copy link

I noticed this issue too as a helper in a recent workshop.

The current text could be expanded to elaborate on units of the spatial grid vs the variable(s). In this case, I don't see the elevation units specified in the tutorial or the raster's metadata. It is sometimes the case that we can't use R to get the variable units, so that could be mentioned. A more satisfying answer would be to point to where you could find the answer for this example. The documentation for NEON LiDAR elevation doc available from here mentions elevation in meters, but the EML file would be more explicit. Unfortunately, I don't see the EML files from NEON in the data folders on figshare.

Or the current text can be simplified to not mention the units of elevation and only ask about CRS units to make the answer more appropriate.

I'd be happy to do the PR if I knew what direction is preferred.

@jsta
Copy link
Member Author

jsta commented Jan 11, 2023

A PR would be great @HeatherSavoy-USDA!

I like option no. 1 (mentioning that we often need to look at the data documentation to get the units, and linking to the NEON page). I see that they have a DOI for the data (https://doi.org/10.48443/ymmp-fr93). I think it would be a good idea to use that instead of a direct link in case NEON changes the location of the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants