Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu items in top menu bar does not display correctly #556

Open
chendaniely opened this issue Jan 4, 2021 · 6 comments
Open

Menu items in top menu bar does not display correctly #556

chendaniely opened this issue Jan 4, 2021 · 6 comments

Comments

@chendaniely
Copy link

chendaniely commented Jan 4, 2021

I'm running Firefox 84.0.1 (64-bit) on Manjaro Linux using KDE
and the top menu bar for the data carpentry website does not toggle the navbar correctly as the browser window resizes horizontally.
This only happens on the DC website, not the SWC or LC websites.

when it's "narrow" (< 1027 pixels) the navbar correctly turns into the "hamburger" bar,
image

However, between 1027 - 1217 (inclusive) the "Home" to "For Instructors" options disappear, only showing "Sponsors, Contact, Search".
edit: It actually does not disappear, the "Home" to "For Instructors" actually show on a second line that gets covered up by the banner photo.
image

pixels >= 1218 wide it displays correctly.
image

@maneesha
Copy link
Contributor

Thanks for catching this @chendaniely
We'll look into updating the theme this website uses to see if that fixes things.

@fmichonneau
Copy link
Member

the problem comes from the fact that the template wasn't designed to include something other than "contact" and "search" on the right corner. By adding "sponsors", the responsiveness gets broken.

@maneesha
Copy link
Contributor

Thanks for catching the problem @fmichonneau

@serahrono do you have suggestions from a communications perspective of how to handle this? We could keep it as is, or we could remove the "sponsors" option. What do you think? I appreciate your feedback!

@maneesha
Copy link
Contributor

Pinging @serahrono

@maneesha
Copy link
Contributor

OK, I just tried to remove the "Sponsor" item from the right side of the tool bar and still get the same effect.
@fmichonneau do you have any other suggestions as to what might cause this?

dc_menubar

@sstevens2
Copy link
Contributor

Ran into this issue myself today. Thanks @chendaniely for your excellent issue description! Mine wasn't going to be nearly as descriptive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants