Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tsdf.select("*") throws Exception stating columns must be present when they are by nature of the projection #248

Open
R7L208 opened this issue Aug 26, 2022 · 1 comment · May be fixed by #272
Open

tsdf.select("*") throws Exception stating columns must be present when they are by nature of the projection #248

R7L208 opened this issue Aug 26, 2022 · 1 comment · May be fixed by #272
Assignees
@tnixon
Labels
bug Something isn't working
Milestone
API Enhancements

Comments

@R7L208
Copy link
Contributor

R7L208 commented Aug 26, 2022

Current behavior produces the below Exception:
Exception: In TSDF's select statement original ts_col, partitionCols and seq_col_stub(optional) must be present

However by nature of select("*") they will be present in the data frame if they exist

Expected Behavior

tsdf.select("*") should succeed and return all columns, including those defined for ts_col, partitionCols, and seqCol
@R7L208 R7L208 added the bug Something isn't working label Aug 26, 2022
@R7L208 R7L208 changed the title tsdf.select("*") throws Exception stating columns included in the projection must be present tsdf.select("*") throws Exception stating columns must be present when they are by nature of the projection Aug 26, 2022
@tnixon tnixon self-assigned this Sep 19, 2022
@tnixon
Copy link
Contributor

tnixon commented Sep 19, 2022

This is a tricky one that'll take some thought as to how to deal with...
We want to support all the types of expressions that you could use within a select, but understanding which ones will modify the structure of a TSDF such that we should issue an exception and which won't is non-trivial.

@R7L208 R7L208 linked a pull request Oct 25, 2022 that will close this issue
Draft
@tnixon tnixon linked a pull request Oct 31, 2022 that will close this issue
Metadata cleanup #272
Draft
@tnixon tnixon added this to the 0.2 milestone Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tnixon tnixon

Labels
bug Something isn't working
Projects
None yet
Milestone
API Enhancements
Development

Successfully merging a pull request may close this issue.

Metadata cleanup databrickslabs/tempo
2 participants
@tnixon @R7L208