Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing DataFrame/Series/Index APIs #362

Closed
HyukjinKwon opened this issue May 20, 2019 · 13 comments · Fixed by #379
Closed

Implement missing DataFrame/Series/Index APIs #362

HyukjinKwon opened this issue May 20, 2019 · 13 comments · Fixed by #379
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@HyukjinKwon
Copy link
Member

HyukjinKwon commented May 20, 2019

I am opening this as a reminder. Probably I might keep opening and closing for each release - not sure yet about it. I don't intend to open this so long time.

To get to the point, eventually we should fix all of the missing APIs here:
https://github.com/databricks/koalas/blob/master/databricks/koalas/missing/series.py
https://github.com/databricks/koalas/blob/master/databricks/koalas/missing/frame.py
https://github.com/databricks/koalas/blob/master/databricks/koalas/missing/indexes.py
https://github.com/databricks/koalas/blob/master/databricks/koalas/missing/groupby.py

Please open a separate issue to start to work on implementing them.

@HyukjinKwon HyukjinKwon added the enhancement New feature or request label May 20, 2019
@HyukjinKwon HyukjinKwon pinned this issue May 20, 2019
@HyukjinKwon HyukjinKwon added the help wanted Extra attention is needed label May 20, 2019
@HyukjinKwon HyukjinKwon changed the title Implement missing Series APIs Implement missing DataFrame/Series APIs May 21, 2019
@HyukjinKwon HyukjinKwon changed the title Implement missing DataFrame/Series APIs Implement missing DataFrame/Series/Index APIs May 21, 2019
@abishekganesh72
Copy link
Contributor

@HyukjinKwon any particular functions that need to be done first?

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented May 23, 2019

I don't have in my mind yet. We should implement all of them (unless it violates our design principles) and I wanted to pin the reminder for now :).

HyukjinKwon pushed a commit that referenced this issue May 24, 2019
@HyukjinKwon HyukjinKwon reopened this May 24, 2019
@HyukjinKwon
Copy link
Member Author

hey @garawalid, let's file a separate issue next time just for separate trackability

@garawalid
Copy link
Collaborator

@HyukjinKwon Okay. I'll open one that contains missing methods for 10-minute tutorial with Koalas (#196)

@shril
Copy link
Contributor

shril commented May 30, 2019

@HyukjinKwon, @garawalid, @abishekganesh72, for the sake of convenience, let's pick up 10 functions for now and in the meantime, we can add more to this list.
This will ultimately help us with better communication between contributors.

I am selecting 10 frequently used unsupported functions for frame.py -

  • add
  • aggregate
  • dot
  • eq
  • first
  • keys
  • last
  • info
  • items
  • le

@shril
Copy link
Contributor

shril commented May 30, 2019

I am starting with DataFrame.first(), DataFrame.last() and DataFrame.keys().

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented May 30, 2019

sounds good :-). Actually, can you get rid of add in the list? I plan to do them all like #401

I plan to add those:

  • add
  • radd
  • div
  • divide
  • rdiv
  • truediv
  • rtruediv
  • mul
  • multiply
  • rmul
  • sub
  • substract
  • rsub

soon at frame.py in one go.

If somebody takes this one, then it's even better to me :-).

@shril
Copy link
Contributor

shril commented May 31, 2019

@HyukjinKwon, I already have 2 PRs on my plate.
I will take it once I complete my set of functions.

@HyukjinKwon
Copy link
Member Author

I opened a PR for mine, #427

@manuzhang
Copy link
Contributor

@shril Any progress on your remaining functions ?

@HyukjinKwon
Copy link
Member Author

@manuzhang feel free to take over if we don't get response within few days.

@xinrong-meng
Copy link
Contributor

xinrong-meng commented Nov 24, 2020

Hi @HyukjinKwon, since we have #1929 for tracking missing API, shall we close this issue? Thank you!

@ueshin ueshin unpinned this issue Nov 24, 2020
@itholic
Copy link
Contributor

itholic commented Nov 25, 2020

Hi @HyukjinKwon, since we have #1929 for tracking missing API, shall we close this issue? Thank!

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants