Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox component has warning #1056

Open
yhrchan opened this issue May 16, 2021 · 3 comments
Open

Checkbox component has warning #1056

yhrchan opened this issue May 16, 2021 · 3 comments
Assignees

Comments

@yhrchan
Copy link

yhrchan commented May 16, 2021

Checked out code, run npm install, then yarn start, accessed demo via localhost:8080

Steps to reproduce:

  1. go to MUI demo
  2. drag CHECKBOX component to form builder
  3. enter in a value for "Label"
  4. click the plus sign besides Options in the Properties Editor
  5. click the plus sign again to create a 2nd options entry

Two warning messages encountered:

react-dom.development.js:88 Warning: The tag is unrecognized in this browser. If you meant to render a React component, start its name with an uppercase letter.
in checkbox (created by ForwardRef(ButtonBase))
in ForwardRef(ButtonBase) (created by WithStyles(ForwardRef(ButtonBase)))
in WithStyles(ForwardRef(ButtonBase)) (created by ForwardRef(IconButton))
in ForwardRef(IconButton) (created by WithStyles(ForwardRef(IconButton)))
in WithStyles(ForwardRef(IconButton)) (created by ForwardRef(SwitchBase))
in ForwardRef(SwitchBase) (created by WithStyles(ForwardRef(SwitchBase)))
in WithStyles(ForwardRef(SwitchBase)) (created by ForwardRef(Checkbox))
in ForwardRef(Checkbox) (created by WithStyles(ForwardRef(Checkbox)))
in WithStyles(ForwardRef(Checkbox)) (created by FinalCheckbox)
in label (created by ForwardRef(FormControlLabel))
in ForwardRef(FormControlLabel) (created by WithStyles(ForwardRef(FormControlLabel)))
in WithStyles(ForwardRef(FormControlLabel)) (created by FinalCheckbox)
in FinalCheckbox (created by SingleCheckbox)
in SingleCheckbox (created by MultipleChoiceList)
in div (created by ForwardRef(FormGroup))
in ForwardRef(FormGroup) (created by WithStyles(ForwardRef(FormGroup)))
in WithStyles(ForwardRef(FormGroup)) (created by Wrapper)
in fieldset (created by ForwardRef(FormControl))
in ForwardRef(FormControl) (created by WithStyles(ForwardRef(FormControl)))
in WithStyles(ForwardRef(FormControl)) (created by Wrapper)
in div (created by ForwardRef(Grid))
in ForwardRef(Grid) (created by WithStyles(ForwardRef(Grid)))

Warning: Encountered two children with the same key, 1621206633539-. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
in div (created by ForwardRef(FormGroup))
in ForwardRef(FormGroup) (created by WithStyles(ForwardRef(FormGroup)))
in WithStyles(ForwardRef(FormGroup)) (created by Wrapper)
in fieldset (created by ForwardRef(FormControl))
in ForwardRef(FormControl) (created by WithStyles(ForwardRef(FormControl)))
in WithStyles(ForwardRef(FormControl)) (created by Wrapper)
in div (created by ForwardRef(Grid))
in ForwardRef(Grid) (created by WithStyles(ForwardRef(Grid)))
in WithStyles(ForwardRef(Grid)) (created by Wrapper)
in Wrapper (created by MultipleChoiceList)
in MultipleChoiceList (created by MultipleChoiceList)
in MultipleChoiceList (created by Checkbox)
in Checkbox (created by ComponentWrapper)
in div (created by ComponentWrapper)
in ComponentWrapper (created by Draggable)
in div (created by ForwardRef(Paper))
in ForwardRef(Paper) (created by WithStyles(ForwardRef(Paper)))
in WithStyles(ForwardRef(Paper)) (created by ForwardRef(Card))
in ForwardRef(Card) (created by WithStyles(ForwardRef(Card)))
in WithStyles(ForwardRef(Card)) (created by FieldLayout)
in div (created by FieldLayout)
in FieldLayout (created by Draggable)
in div (created by Draggable)
in Draggable (created by Connect(Draggable))
in Connect(Draggable) (created by PrivateDraggable)
in PrivateDraggable (created by PublicDraggable)
in PublicDraggable

@Hyperkid123 Hyperkid123 self-assigned this May 17, 2021
@Hyperkid123 Hyperkid123 transferred this issue from data-driven-forms/form-builder May 24, 2021
@Hyperkid123
Copy link
Member

@yhrchan
The issue number will be fixed in the next release (should be published soon)

The second issue is caused when a field with a duplicate name is added to the builder. It is fixed by default in the new form builder version we want to release soon. It's on this branch: https://github.com/data-driven-forms/form-builder/tree/dnd-kit

We had to slow down a bit in the past few weeks because of other responsibilities but we will get back to the development soon.

@yhrchan
Copy link
Author

yhrchan commented May 26, 2021 via email

@rvsia
Copy link
Contributor

rvsia commented May 26, 2021

@yhrchan

I can provide some information. Yes, there is probably still a lot of work to do on the dnd-kit branch but we got the most important thing to work already - it supports nested components unlike the beatiful-dnd. And that’s the reason why we choose to use different d&d package, because of the nesting. Without that, the form builder is too limited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants