Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from setup.py to pyproject.toml #305

Closed
jakirkham opened this issue Mar 27, 2023 · 3 comments · Fixed by #306
Closed

Move from setup.py to pyproject.toml #305

jakirkham opened this issue Mar 27, 2023 · 3 comments · Fixed by #306

Comments

@jakirkham
Copy link
Member

Increasingly there is a move by Python projects to use pyproject.toml to declare their metadata and dependencies and away from setup.py. Raising this issue to start discussion around how to approach this in Dask-image.

Related upstream issues:
@GenevieveBuckley GenevieveBuckley mentioned this issue Mar 29, 2023
Merged
@GenevieveBuckley
Copy link
Collaborator

The only points for discussion I can think of are:

  • flake8 is not supported in pyproject.toml files directly, we'd need to add Flake8-pyproject as a dependency
  • ...there are additional flake8 problems unrelated to this, I'll open another issue to discuss

@GenevieveBuckley
Copy link
Collaborator

Hm, perhaps one other problem is that with the pyrpoject.toml setup, it looks as though dask-image version 0.0.0 is installed for the development version. That is what appears in the conda list, and I think that'll end up being a bit of a problem. (But if you import dask-image and check the version string, you see the expected version)

@GenevieveBuckley
Copy link
Collaborator

Maybe FlakeHell. This blogpost seems encouraging: https://dev.to/bowmanjd/using-flake8-and-pyproject-toml-with-flakehell-1cn1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to pyproject.toml package setup GenevieveBuckley/dask-image
2 participants
@jakirkham @GenevieveBuckley