Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports from various example ENV files and configs don't match up #1719

Open
coolaj86 opened this issue Feb 26, 2024 · 0 comments
Open

Ports from various example ENV files and configs don't match up #1719

coolaj86 opened this issue Feb 26, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@coolaj86
Copy link

coolaj86 commented Feb 26, 2024

This is a general, widespread issue across this repo as well as many other pieces of documentation.

The port numbers in the various sample config files are inconsistent, incongruent, and otherwise don't actually match up.

For example:

Expected Behavior

All sample configs for testnet should be congruent across the board. It should be sufficient to copy the example config to the correct place and be able to run as is.

Even though many of the ports are completely arbitrary, we should just have a table of "standard testnet ports" with a note like this:

These ports are arbitrary, but must be consistent within the network of evo node services. Feel free to change them if they conflict with other services on your system, or for your own whimsy.

And we should mark bugs for any ports that are hard-coded to be fixed in the respective codebase or message type (such as protxreg) as soon as reasonable.

Current Behavior

It's a mix mash.

Possible Solution

Create a table and place it prominently in all repos, and update the config files as soon as reasonable.

Service Env Address Default Port Hard-Coded Port Public
core p2p testnet 127.0.0.1 19999 - YES
core rpc testnet 127.0.0.1 19998 - -
core zmq testnet 127.0.0.1 18009 - -
drive api json testnet 127.0.0.1 2501 - -
drive api grpc testnet 127.0.0.1 2500 - -
drive streams testnet 127.0.0.1 2510 - -
tenderdash p2p testnet 127.0.0.1 26656 - YES
tenderdash rpc testnet 127.0.0.1 26657 - -
envoy-to-dapi testnet 0.0.0.0 10000 YES YES

Use a common config profile files across multiple services rather than having duplicate config files with the same addresses and ports for each service.

~/.config/dash/testnet.json
~/.config/dash/testnet.env

Steps to Reproduce (for bugs)

  1. Copy the sample config files
  2. Run the services
  3. See that they can't actually reach each other

Context

It's just a lot of mental overhead to go back and forth between configs.

Your Environment

Any.

@coolaj86 coolaj86 added the bug Something isn't working label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant