Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(dpp): WASM DPP bundle doubled in size #1626

Open
pshenmic opened this issue Dec 8, 2023 · 3 comments
Open

bug(dpp): WASM DPP bundle doubled in size #1626

pshenmic opened this issue Dec 8, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@pshenmic
Copy link
Collaborator

pshenmic commented Dec 8, 2023

Expected Behavior

WASM DPP shouldn't weight too much to be able to easily include in Browser & Mobile environments.

Current Behavior

WASM DPP JS bundle recently raised in size at least twice from 12 MB to 30 MB, and including all sourcemaps the final Dash SDK bundle raised to unbelievable 72 MB. This is not acceptable for a browser environment as it is drastically increases page load times.

image

Possible Solution

Revise changes between 0.25.13 and 0.25.15 releases, and make more optimization and cut unncessary stuff. Also, might be a good idea to disable wasm dpp source maps

Context

That happened on 0.25.15 release, because 0.25.13 JS bundle weights about twice less.

@pshenmic pshenmic added the bug Something isn't working label Dec 8, 2023
@coolaj86
Copy link

coolaj86 commented Feb 9, 2024

I'm seeing 9.1M which is just mind-blowingly HUGE.

What's going on here? What does this thing even do?

Why not use the modern, native js Dash Incubator libraries? Is there something that they don't support yet that has to be included? If so, how about we just fix the Dash Incubator libs to have the necessary functionality?

https://github.com/dashhive/dash-tools

@riongull
Copy link

@coolaj86, I spoke about this size issue in our last Incubator quarterly call. Our plan is to add Dash Platform support in our tools, so that will be an issue for our repos. DCG can feel free to close this issue if they don't see an issue in their tools.

@kxcd
Copy link

kxcd commented Feb 11, 2024

Does it cache? If so, it is not such a big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants