Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adjust API of submitchainlock #5805

Open
PastaPastaPasta opened this issue Jan 9, 2024 · 0 comments
Open

feat: Adjust API of submitchainlock #5805

PastaPastaPasta opened this issue Jan 9, 2024 · 0 comments

Comments

@PastaPastaPasta
Copy link
Member

Talked to Sam; we want change the API in this way
First (if height <= bestchainlockheight return bestchainlockheight)
else submitchainlock then return bestchainlockheight

This provides two benefits; 1st is a short circuiting if we know the proposed chainlock could not overwrite the current one (due to lower height)
Second; returns the bestchainlockheight to platform

Originally posted by @PastaPastaPasta in #5765 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant