Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would TLS support be useful? #188

Open
tcoats opened this issue Sep 4, 2019 · 6 comments
Open

Would TLS support be useful? #188

tcoats opened this issue Sep 4, 2019 · 6 comments

Comments

@tcoats
Copy link

tcoats commented Sep 4, 2019

I have multiple Raspberry Pis in a potentially hostile network. I'd like to use cote for discovery and communication, replicating data across all nodes. I've produced a similar library to cote — odo-journal. I'd rather use something with more people behind it.

Odo Journal currently uses TLS encryption where each node has a ca, key and cert. The ca is so we can rotate keys from an external secret key that is not available on each node. Every node has both the key and the cert so it's not asymmetric encryption, but it does address a man in the middle attack.

I'd see the use of TLS similar to how the environment property works, it would partition the network.

Does this have a place in cote?

@dashersw
Copy link
Owner

dashersw commented Sep 4, 2019

Exactly, we’d love to implement TLS — however no one has gone to the length to implement it. If you’d consider contributing, you’d be welcome.

@tcoats
Copy link
Author

tcoats commented Sep 5, 2019

It looks like the heavy lifting would be in axon, in sock.js. At the moment all connections are via net, we'd need to add tls as an option. The changes needed in cote would be passing configuration parameters through.

Are your changes to axon likely to be upstreamed to tj's repo? I'm wondering if we need to line up with that project's vision.

@tcoats
Copy link
Author

tcoats commented Sep 5, 2019

Looking at the pull requests, someone has implemented tls. I haven't had a look, but could this potentially be merged into your branch?

We'd need to review the changes for suitability.

@dashersw
Copy link
Owner

dashersw commented Sep 5, 2019

Looks interesting! Some lines seem redundant, but if you can make it work within cote, we can merge it and release as a newer version of @dashersw/axon.

@dashersw
Copy link
Owner

dashersw commented Sep 5, 2019

Sorry, didn’t see your previous message. Axon is probably dead at this point, so I would assume not.

@otothea
Copy link
Contributor

otothea commented Sep 5, 2019

@tcoats I would like to see this feature supported by cote as well, let me know if you need/want any help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants