Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Action Module Playground & Components Missing Imports #97

Merged
merged 4 commits into from Jun 4, 2020

Conversation

mdelez
Copy link
Contributor

@mdelez mdelez commented Jun 4, 2020

@mdelez mdelez self-assigned this Jun 4, 2020
@mdelez mdelez added the bug Something isn't working label Jun 4, 2020
@tobiasschweizer
Copy link
Contributor

The warnings when running the test are gone :-)

I still get this when building the lib

WARNING: No name was provided for external module 'ts-md5' in output.globals – guessing 'tsMd5'

You can simply add an entry to projects/dsp-ui/ng-package.json

@mdelez
Copy link
Contributor Author

mdelez commented Jun 4, 2020

The warnings when running the test are gone :-)

I still get this when building the lib

WARNING: No name was provided for external module 'ts-md5' in output.globals – guessing 'tsMd5'

You can simply add an entry to projects/dsp-ui/ng-package.json

Ah, sorry I thought you said you wanted a separate PR for this in our call but I'm okay doing it in this one.

Fixed in 3c42030 😄

@tobiasschweizer
Copy link
Contributor

Ah, sorry I thought you said you wanted a separate PR for this in our call but I'm okay doing it in this one.

Yes, I said this, sorry. I should be more consistent :-)

@@ -7,7 +7,8 @@
"@knora/api": "@knora/api",
"ngx-color-picker": "ngxColorPicker",
"jdnconvertiblecalendar": "jdnconvertiblecalendar",
"jdnconvertiblecalendardateadapter": "jdnconvertiblecalendardateadapter"
"jdnconvertiblecalendardateadapter": "jdnconvertiblecalendardateadapter",
"ts-md5": "Md5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be "tsMd5" on the right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both seem to work but I changed it to "tsMd5" in 91d6b27

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you can put what you want, I don't know. "tsMd5" is just what the compiler guessed.

Copy link
Contributor

@tobiasschweizer tobiasschweizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

And sorry for being confused myself about my on proposals.

@mdelez mdelez merged commit 03cc104 into master Jun 4, 2020
@mdelez mdelez deleted the fix/DSP-333-Tests-ActionPlaygroundComponent branch June 4, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants