Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapped components getter refactor #44

Open
mdelez opened this issue Mar 16, 2020 · 4 comments
Open

Wrapped components getter refactor #44

mdelez opened this issue Mar 16, 2020 · 4 comments
Assignees

Comments

@mdelez
Copy link
Contributor

mdelez commented Mar 16, 2020

After discussing with Tobias, we think that the getter method in a wrapped component should only check the validity of the form if possible instead of checking each FormControl for specific criteria since the form will be valid if all the criteria is met. We should make this change on all of the wrapped components.

Old method
https://github.com/dasch-swiss/knora-ui-ng-lib/blob/43ee1e8697784eea36cd1de0fb3d012e5d8d25a8/projects/knora-ui/src/lib/viewer/values/time-value/time-input/time-input.component.ts#L123-L129

New method
https://github.com/dasch-swiss/knora-ui-ng-lib/blob/692226bd8d9d5a93e5d78d68fe69254a45796a68/projects/knora-ui/src/lib/viewer/values/time-value/time-input/time-input.component.ts#L123-L129

@tobiasschweizer
Copy link
Contributor

I will submit a related PR for angular/components#18817

@tobiasschweizer
Copy link
Contributor

Angular custom form field example fixed in angular/components#18844

@mdelez
Copy link
Contributor Author

mdelez commented Mar 17, 2020

That was quick :) good work!

@tobiasschweizer
Copy link
Contributor

I am not bright but quick ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants