Viewer #2

tobiasschweizer · 2020-01-30T10:41:30Z

check out Export mock factory and test data dsp-js-lib#125
run npm i && npm run yalc-publish
run yalc add @knora/api for this repo
run npm i for this repo
run ng b --project knora-ui for this repo
run ng s for this repo

closes #1
closes #4

…out some weird typing problems ...)

tobiasschweizer · 2020-02-10T08:11:57Z

projects/knora-ui/src/lib/viewer/values/base-value.component.ts

@@ -25,6 +25,8 @@ export abstract class BaseValueComponent {

  form: FormGroup;

+  abstract customValidators: ValidatorFn[];


@mdelez I added the abstract member customValidators that has to be implemented for each value type or set to an empty array if not needed.

Very nice :)

…dated a value that already has a comment

…ponents

Tobias Schweizer added 9 commits January 29, 2020 10:05

feature (app): add an Angular app

64b4f7d

feature (lib): add an Angular library

882745f

refactor (package.json): add dependencies

a1fb290

feature (core): add core module

935819a

feature (viewer): add basic structure

a5a96de

feature (values): add component for text

271a719

feature (values): text value as string comp.

2fa0ff3

test (value): add tests for text as string value component

8294fa1

feature (values): do not return invalid values

2c546d1

tobiasschweizer self-assigned this Jan 30, 2020

Tobias Schweizer and others added 12 commits January 30, 2020 11:48

test (value): add tests for text as string value component

1a8b787

feature (app): add test env for value editing

bc38701

feature (app): edit and save a value

b3418d2

feature (app): create and save a value

cdacac0

feature (app): create and save a value

9f71f8c

test (value): add tests for text as string value component

dcedb03

feature (values): move some logic to base class

a04e884

feature (value): combine value and comment validator

050d0c1

feature (value): combine value and comment validator

8a2106d

feature (app): get rid of nested subscriptions (still need to figure …

e6559be

…out some weird typing problems ...)

feature (value): add integer value component

6ab3b1f

feature (values): add custom validators

dbf5475

tobiasschweizer commented Feb 10, 2020

View reviewed changes

Tobias Schweizer and others added 5 commits February 10, 2020 09:37

feature (value): add comments to members of the base class

7ed459d

test (value): add tests for creating a text value

96cf770

feature (CRUD operations): add component to edit and display a value

62e660b

test (value): optimize creating text value tests and add tests for up…

e9feabe

…dated a value that already has a comment

feature (CRUD operations): use display edit component

7b18dfd

mdelez requested review from mdelez and removed request for mdelez February 12, 2020 08:34

Tobias Schweizer and others added 13 commits February 12, 2020 10:08

feature (app init): add app init service

45f5c93

test (CRUD operations): add test for DisplayEditComponent

41d2e11

test (CRUD operations): add test for DisplayEditComponent

edc2199

fix (CRUD operations): fix import

e6b23ee

test (CRUD operations): add test for DisplayEditComponent

da11edb

test (CRUD operations): improve test for DisplayEditComponent

2d9d8f8

refactor (selector prefix): change prefix to kui

90f2a50

refactor (values): reformat file, remove selectors on test parent com…

7826bc5

…ponents

test (values): add test for IntValueComponent

f726a75

test (values): refactored test values

162f77a

test (values): added more tests for displaying IntValueComponent

87aa27d

test (values): added tests for creating an int value

6f5541f

test (values): added test for unsubscribing when destroyed

7c5c53e

mdelez approved these changes Feb 13, 2020

View reviewed changes

tobiasschweizer merged commit dfd3f51 into master Feb 13, 2020

tobiasschweizer deleted the wip/1-viewer-structure branch February 13, 2020 15:04

tobiasschweizer mentioned this pull request Feb 13, 2020

Viewer Value Component: IntValueComponent #7

Closed

mpro7 added a commit that referenced this pull request Oct 19, 2020

bug(action): fix bad merge #2

13624d3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Viewer #2

Viewer #2

tobiasschweizer commented Jan 30, 2020 •

edited

tobiasschweizer Feb 10, 2020

mdelez Feb 10, 2020

		@@ -25,6 +25,8 @@ export abstract class BaseValueComponent {

		form: FormGroup;

		abstract customValidators: ValidatorFn[];

Viewer #2

Viewer #2

Conversation

tobiasschweizer commented Jan 30, 2020 • edited

tobiasschweizer Feb 10, 2020

Choose a reason for hiding this comment

mdelez Feb 10, 2020

Choose a reason for hiding this comment

tobiasschweizer commented Jan 30, 2020 •

edited