feat(viewer): recognise URLs in text value and convert into link (DSP-1595) #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is how it works: Screen.Recording.2021-07-13.at.15.46.02.mov |
mdelez
requested changes
Jul 14, 2021
| let stylizedText: string = ''; | ||
| if (value && value.length > 0) { | ||
| for (let str of value.split(' ')) { | ||
| // if string/url ends with a full stop '.' or column ':' the pipe will not recognize the url |
There was a problem hiding this comment.
This comment should be updated to align with line 19. Also, ':' is called a colon in english :)
There was a problem hiding this comment.
oh yes... colon, not column
fixed in 29c25eb
| }) | ||
| export class LinkifyPipe implements PipeTransform { | ||
|
|
||
| // constructor(private _domSanitizer: DomSanitizer) { } |
There was a problem hiding this comment.
removed in 29c25eb
| import { Pipe, PipeTransform } from '@angular/core'; | ||
|
|
||
| /** | ||
| * This pipe analyses a string and converts any url into a href tags |
There was a problem hiding this comment.
fixed in 29c25eb
mdelez
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DSP-1595
s. comment: https://dasch.myjetbrains.com/youtrack/issue/DSP-1595#focus=Comments-4-3243.0-0