chore(update): update cal lib and date adapter (DSP-1758) #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gautschr Could you try to choose the BC date which had the wrong number of days in February ? |
tobiasschweizer
changed the title
|
They work now! |
tobiasschweizer
commented
Jun 22, 2021
| @@ -262,8 +262,8 @@ describe('ValueService', () => { | |||
|
|
|||
| const period = calDateJDN.toJDNPeriod(); | |||
|
|
|||
| expect(period.periodStart).toEqual(1721060); | |||
| expect(period.periodEnd).toEqual(1721060); | |||
| expect(period.periodStart).toEqual(1721058); | |||
There was a problem hiding this comment.
@gautschr I had to adapt these expectations.
The Gregorian calendar date of January 1st 1 BCE used to be 1721060 in JDN, now it is 1721058.
Since the date is before 1582, it was calculated like a Julian calendar date, right?
gautschr
approved these changes
Jun 23, 2021
| @@ -262,8 +262,8 @@ describe('ValueService', () => { | |||
|
|
|||
| const period = calDateJDN.toJDNPeriod(); | |||
|
|
|||
| expect(period.periodStart).toEqual(1721060); | |||
| expect(period.periodEnd).toEqual(1721060); | |||
| expect(period.periodStart).toEqual(1721058); | |||
mdelez
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DSP-1758