Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(viewer): improve editing of geonames (DSP-1212) #307

Merged
merged 11 commits into from Jun 21, 2021
Merged

feat(viewer): improve editing of geonames (DSP-1212) #307

merged 11 commits into from Jun 21, 2021

Conversation

tobiasschweizer
Copy link
Contributor

@tobiasschweizer tobiasschweizer commented Jun 17, 2021 •
edited

resolves DSP-1212

TODOs:

  • make sure geoname id is always represented as a string
  • make sure that geonames API returns results in the same language (display and search)
  • see if there is a way to preserve the display name when switching to edit mode

@tobiasschweizer tobiasschweizer self-assigned this Jun 17, 2021
@tobiasschweizer tobiasschweizer changed the title feat(viewer): return more detailed information for geonames (DSP-1212) feat(viewer): improve editing of geonames (DSP-1212) Jun 17, 2021
gautschr
gautschr approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@gautschr gautschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works nicely, thank you!

mdelez
mdelez approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :D

@tobiasschweizer tobiasschweizer merged commit 91bb637 into main Jun 21, 2021
@tobiasschweizer tobiasschweizer deleted the wip/dsp-1212-geonames branch June 21, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gautschr gautschr gautschr approved these changes

@mdelez mdelez mdelez approved these changes

Assignees

@tobiasschweizer tobiasschweizer

Labels
user requirement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tobiasschweizer @gautschr @mdelez