Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(viewer): improve style of date input (DSP-1724) #301

Merged
merged 3 commits into from Jun 10, 2021
Merged

feat(viewer): improve style of date input (DSP-1724) #301

merged 3 commits into from Jun 10, 2021

Conversation

tobiasschweizer
Copy link
Contributor

resolves DSP-1724

@tobiasschweizer tobiasschweizer added the enhancement New feature or request label Jun 9, 2021
@tobiasschweizer tobiasschweizer self-assigned this Jun 9, 2021
mdelez
mdelez requested changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest modifying the CSS so that there isn't so much space between the two inputs like this:

Screen Shot 2021-06-10 at 11 58 28

@tobiasschweizer
Copy link
Contributor Author

@mdelez How do you like 8c966f3?

@mdelez mdelez self-requested a review June 10, 2021 11:34
@tobiasschweizer
Copy link
Contributor Author

@gautschr Would you like to have a look at this PR? It's just a small adaption of CSS.

@tobiasschweizer tobiasschweizer merged commit 4c3d1b3 into main Jun 10, 2021
@tobiasschweizer tobiasschweizer deleted the wip/dsp-1724-date-ui branch June 10, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gautschr gautschr gautschr approved these changes

@mdelez mdelez mdelez approved these changes

Assignees

@tobiasschweizer tobiasschweizer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tobiasschweizer @gautschr @mdelez