feat(advanced search): specify linked resource (DSP-1587)

[tobiasschweizer]

resolves DSP-1587

TODOs:

• distinguish between specifying a resource and searching by its label to get its IRI in projects/dsp-ui/src/lib/search/advanced-search/select-property/specify-property-value/specify-property-value.component.html -> 062875c
  • [ ] form should be invalid unless the user specified at least one property on the linked resource -> seems now unnecessary to me since this can behave like EXIST when no props are specified
  • consider resource class restriction on linked resource
• use knora-api:Resource as fallback for object class restriction on linking props
• make linked resource var unique using a call counter
• only allow sort criteria on top level
• limit specification of linked resource to one level only (only main form and one additional level)
• extend Gravsearch generation service so it can deal with linked resources

[tobiasschweizer]

@loicjaouen The best way to test this is using the playground app:

• http://localhost:4200/search (submits the queries to the local DSP-API instance -> you can search for actual data)
• http://localhost:4200/advanced-search (just produces Gravsearch)

[tobiasschweizer]

@kilchenmann I think I should document the comparison operators somewhere (user docs).
Could I add this to https://github.com/dasch-swiss/dsp-ui-lib/blob/b436a310a48a565e01c2511abdfa97252478db7f/docs/how-to-use/search/extended-search.md?

[kilchenmann]

@kilchenmann I think I should document the comparison operators somewhere (user docs).
Could I add this to https://github.com/dasch-swiss/dsp-ui-lib/blob/b436a310a48a565e01c2511abdfa97252478db7f/docs/how-to-use/search/extended-search.md?

Yes that would be good 👍

[tobiasschweizer]

@gautschr to test this in the playground app, follow these steps: https://dasch-swiss.github.io/dsp-ui-lib/how-to-contribute/#first-steps

Then you can access these two pages:

• http://localhost:4200/search (submits the queries to the local DSP-API instance -> you can search for actual data)
• http://localhost:4200/advanced-search (just produces Gravsearch)

[tobiasschweizer]

@flavens I tested it using the following scenario:

Anything:Thing -> another Thing -> matches (Anything:Thing -> Decimal number -> > 0.5)

Then I added other props on the top level and also on the linked resource.

However, it is important to test it with a different ontology with some actual project data.
I'll try to test it with BEOL data rom the staging server.

[tobiasschweizer]

@kilchenmann I think I should document the comparison operators somewhere (user docs).
Could I add this to https://github.com/dasch-swiss/dsp-ui-lib/blob/b436a310a48a565e01c2511abdfa97252478db7f/docs/how-to-use/search/extended-search.md?

Yes that would be good 👍

Could it be that https://github.com/dasch-swiss/dsp-ui-lib/blob/b436a310a48a565e01c2511abdfa97252478db7f/docs/how-to-use/search/extended-search.md is outdated? The component is now called advanced search component, also the parameters do not fit. Wouldn't it be good to have an example that fits the screenshot too?

[tobiasschweizer]

I'll work on the user docs in DSP-1651

[gautschr]

It works, thank you! I tested it locally with two different sets of data.

[tobiasschweizer]

@kilchenmann @subotic The E2E test fails because of an authentication problem:

Bad credentials
https://github.com/dasch-swiss/dsp-ui-lib/pull/293/checks?check_run_id=2636678076#step:3:52

Any idea what to do about this?

[kilchenmann]

It works fine.
We have to think about the design, but this will be part of the next iteration, right? I will move the current mockup from Balsamiq to Figma.

[kilchenmann]

@kilchenmann @subotic The E2E test fails because of an authentication problem:

Bad credentials
https://github.com/dasch-swiss/dsp-ui-lib/pull/293/checks?check_run_id=2636678076#step:3:52

Any idea what to do about this?

It seems that someone deleted the repository dasch-swiss/dsp-ci-assets

[tobiasschweizer]

@kilchenmann @subotic The E2E test fails because of an authentication problem:

Bad credentials
https://github.com/dasch-swiss/dsp-ui-lib/pull/293/checks?check_run_id=2636678076#step:3:52

Any idea what to do about this?

It seems that someone deleted the repository dasch-swiss/dsp-ci-assets

fixed in #296

[loicjaouen]

i didn't delve into the code but thanks to @tobiasschweizer instruction, was able to run a query on one of our set: request http://theatresdesociete.unil.ch/ : theatrical Representations based on a play by Molière:

[flavens]

LGTM and as I told you (and André did as well), we should improve the design in a next iteration to make it more intuitive

[loicjaouen]

good to go for this round ;)