Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(update angular): update to Angular 11 (DSP-1472) #286

Merged
merged 11 commits into from Mar 25, 2021

Conversation

tobiasschweizer
Copy link
Contributor

resolves DSP-1472

@tobiasschweizer tobiasschweizer self-assigned this Mar 24, 2021
@tobiasschweizer
Copy link
Contributor Author

tobiasschweizer commented Mar 24, 2021

When running the unit tests, I get

Passing raw CLI options to new Server(config, done) is deprecated. Use parseConfig(configFilePath, cliOptions, {promiseConfig: true, throwErrors: true}) to prepare a processed Config instance and pass that as the config argument instead.

I think this is because of a change in karma 6.3.0: karma-runner/karma@v6.2.0...v6.3.0

-> fixed by downgrading karma in 12f5444

@tobiasschweizer
Copy link
Contributor Author

replay async function with waitForAsync in eca5dae, see https://angular.io/api/core/testing/async

@@ -10,13 +10,13 @@
<mat-card-title class="res-class-value">{{ res.label }}</mat-card-title>
</mat-card-header>
<mat-card-content class="grid-card-content" *ngFor="let prop of res.properties | keyvalue">
<div *ngFor="let val of prop.value | keyvalue">
<div *ngFor="let val of prop.value">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flavens I removed the second keyvalue pipe because of a compiler problem. I think it is not necessary since prop.value is a ReadValue[] and thus iterable.

@@ -12,13 +12,13 @@
<h3 matLine class="res-class-value">{{ res.label }}</h3>

<div matLine *ngFor="let prop of res.properties | keyvalue">
<div matLine *ngFor="let val of prop.value | keyvalue">
<div matLine *ngFor="let val of prop.value">
<span class="res-prop-label">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flavens same change as for the resource grid.

@tobiasschweizer tobiasschweizer changed the title core(update angular): update to Angular 11 (DSP-1472) chore(update angular): update to Angular 11 (DSP-1472) Mar 25, 2021
@tobiasschweizer tobiasschweizer added the chore Maintenance and build tasks label Mar 25, 2021
@tobiasschweizer tobiasschweizer merged commit cdc038c into main Mar 25, 2021
@tobiasschweizer tobiasschweizer deleted the wip/dsp-1472-update-angular branch March 25, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance and build tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants