New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(update angular): update to Angular 11 (DSP-1472) #286
Conversation
When running the unit tests, I get
I think this is because of a change in karma 6.3.0: karma-runner/karma@v6.2.0...v6.3.0 -> fixed by downgrading karma in 12f5444 |
replay |
@@ -10,13 +10,13 @@ | |||
<mat-card-title class="res-class-value">{{ res.label }}</mat-card-title> | |||
</mat-card-header> | |||
<mat-card-content class="grid-card-content" *ngFor="let prop of res.properties | keyvalue"> | |||
<div *ngFor="let val of prop.value | keyvalue"> | |||
<div *ngFor="let val of prop.value"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flavens I removed the second keyvalue
pipe because of a compiler problem. I think it is not necessary since prop.value
is a ReadValue[]
and thus iterable.
@@ -12,13 +12,13 @@ | |||
<h3 matLine class="res-class-value">{{ res.label }}</h3> | |||
|
|||
<div matLine *ngFor="let prop of res.properties | keyvalue"> | |||
<div matLine *ngFor="let val of prop.value | keyvalue"> | |||
<div matLine *ngFor="let val of prop.value"> | |||
<span class="res-prop-label"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flavens same change as for the resource grid.
resolves DSP-1472