Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update the READMEs and init mkDocs (DSP-1298) #271

Merged
merged 46 commits into from Feb 2, 2021

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented Jan 29, 2021

resolves DSP-1298

This PR brings back the dsp-ui documentation from dsp-docs incl. little refactoring (s. description on youtrack). The update of the content and description of each component has to be done in a separate task.
A first version of the documentation is already available on gh page: https://dasch-swiss.github.io/dsp-ui-lib/

@kilchenmann kilchenmann self-assigned this Jan 30, 2021
@kilchenmann kilchenmann added the documentation Improvements or additions to documentation label Jan 30, 2021
Copy link
Collaborator

@flavens flavens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

careful, there is a mix of "DSP-UI-LIB" and "DSP-UI" across different files
see the other comments
the correction of the language typos is probably incomplete

docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/how-to-contribute/index.md Outdated Show resolved Hide resolved
docs/how-to-contribute/index.md Outdated Show resolved Hide resolved

## Demo Application (Playground)

### Adding New Component to the Demo Application
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why having all the words in camelcase in all the titles?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flavens it's how titles are written in English but we should be consistent. The other docs do not have this capitalization. I would suggest using this form of capitalization and changing the titles in the other docs to be the same.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to do these changes in a separate refactor task (by someone who knows the english language better than me). We have to rewrite and update the "how-to-use"-documentation anyway.

Copy link
Contributor

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My review may have gotten a little out of hand...let me know if you would like me to help you out with these changes.

README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/how-to-use/search/index.md Outdated Show resolved Hide resolved
docs/how-to-use/search/index.md Outdated Show resolved Hide resolved
docs/how-to-use/search/search-panel.md Outdated Show resolved Hide resolved
docs/how-to-use/viewer/index.md Outdated Show resolved Hide resolved
docs/how-to-use/viewer/search-results.md Outdated Show resolved Hide resolved
@kilchenmann
Copy link
Contributor Author

kilchenmann commented Feb 2, 2021

careful, there is a mix of "DSP-UI-LIB" and "DSP-UI" across different files
see the other comments
the correction of the language typos is probably incomplete

This is the big question: The repo's called dsp-ui-lib, but we publish it as dsp-ui. The main README will also be used for the published version (e.g. on npm). What do you suggest @flavens: DSP-UI-LIB or DSP-UI?
I prefer to use the term DSP-UI.

Btw.: the term DSP-UI-LIB occurs 9 times in 4 files; DSP-UI occurs 36 times in 11 files.

EDIT: I updated everything to DSP-UI

@kilchenmann
Copy link
Contributor Author

the correction of the language typos is probably incomplete

Yes, this should be done (soon) in a separate refactor task.

@flavens
Copy link
Collaborator

flavens commented Feb 2, 2021

This is the big question: The repo's called dsp-ui-lib, but we publish it as dsp-ui. The main README will also be used for the published version (e.g. on npm). What do you suggest @flavens: DSP-UI-LIB or DSP-UI?
I prefer to use the term DSP-UI.

Btw.: the term DSP-UI-LIB occurs 9 times in 4 files; DSP-UI occurs 36 times in 11 files.

I do not mind, as long as we stay consistent!

Copy link
Collaborator

@flavens flavens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the other things to edit can be done in an other PR as mentioned > approved

Copy link
Contributor

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can assign me to a new PR about fixing typos :)

@kilchenmann kilchenmann merged commit b436a31 into main Feb 2, 2021
@kilchenmann kilchenmann deleted the wip/dsp-1298-update-docs branch February 2, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants