Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSP-806 Add the attribute 'rel' to uri and geoname value component template #207

Merged
merged 1 commit into from Oct 8, 2020
Merged

DSP-806 Add the attribute 'rel' to uri and geoname value component template #207

merged 1 commit into from Oct 8, 2020

Conversation

flavens
Copy link
Collaborator

@flavens flavens commented Oct 8, 2020

resolves DSP-806

@flavens flavens added the enhancement New feature or request label Oct 8, 2020
@flavens flavens self-assigned this Oct 8, 2020
@flavens flavens mentioned this pull request Oct 8, 2020
Closed
tobiasschweizer
tobiasschweizer approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@tobiasschweizer tobiasschweizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for security reasons?

https://developer.mozilla.org/en-US/docs/Web/HTML/Link_types/noopener

@flavens
Copy link
Collaborator Author

flavens commented Oct 8, 2020

Is this for security reasons?

https://developer.mozilla.org/en-US/docs/Web/HTML/Link_types/noopener

Yes, this is what I understood from the tutorial :

To solve both of these issues any link using target="_blank" should also have a rel="noopener" attribute as well. The rel="noopener" attribute makes sure that the new browser tab does not run on the same process and prevent it from accessing window.opener. [...]
This attribute fixes our performance and security issue, but now we must manually check every link in our application to make sure if it is external that it has the appropriate attributes. Luckily for us, we can leverage Angular Directives to automate this for us.

@flavens flavens merged commit c76029a into master Oct 8, 2020
@flavens flavens deleted the wip/dsp-806-add-rel-attribute branch October 8, 2020 09:33
@flavens flavens changed the title DSP-806 - Add the attribute 'rel' to uri and geoname value component template DSP-806 Add the attribute 'rel' to uri and geoname value component template Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasschweizer tobiasschweizer tobiasschweizer approved these changes

@mdelez mdelez Awaiting requested review from mdelez

Assignees

@flavens flavens

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flavens @tobiasschweizer