Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular Material imports should be specific to the component #19

Open
flavens opened this issue Feb 13, 2020 · 2 comments
Open

Angular Material imports should be specific to the component #19

flavens opened this issue Feb 13, 2020 · 2 comments
Assignees
@tobiasschweizer @flavens @mdelez
Labels
chore Maintenance and build tasks documentation Improvements or additions to documentation

Comments

@flavens
Copy link
Collaborator

flavens commented Feb 13, 2020

Directive from the Angular Upgrade Guide:
"Instead of importing from @angular/material, you should import deeply from the specific component. E.g. @angular/material/button. [...]"
@flavens flavens added documentation Improvements or additions to documentation chore Maintenance and build tasks labels Feb 13, 2020
@tobiasschweizer
Copy link
Contributor

Shall we tackle this once all value components have been implemented? Then we could do it consistently.

@flavens
Copy link
Collaborator Author

flavens commented Mar 17, 2020

Shall we tackle this once all value components have been implemented? Then we could do it consistently.

yes

@SepidehAlassi SepidehAlassi removed their assignment Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobiasschweizer tobiasschweizer

@flavens flavens

@mdelez mdelez

Labels
chore Maintenance and build tasks documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tobiasschweizer @SepidehAlassi @flavens @mdelez