Skip to content

Commit

Permalink
fix(Link Value): custom validator should allow null (DSP-1237) (#261)
Browse files Browse the repository at this point in the history
* fix(link-value): custom validator now allows null

* test(link-value): adds test for valueRequiredValidator input set to false
  • Loading branch information
mdelez committed Jan 18, 2021
1 parent cc8b9e1 commit 01da692
Show file tree
Hide file tree
Showing 3 changed files with 451 additions and 393 deletions.
Expand Up @@ -16,7 +16,7 @@
<mat-error *ngIf="valueFormControl.hasError('valueNotChanged')">
<span class="custom-error-message">New value must be different than the current value.</span>
</mat-error>
<mat-error *ngIf="valueFormControl.hasError('invalidType')">
<mat-error *ngIf="valueRequiredValidator && valueFormControl.hasError('invalidType')">
<span class="custom-error-message">New value must be a valid resource type.</span>
</mat-error>
<mat-error *ngIf="valueFormControl.hasError('duplicateValue')">
Expand Down

0 comments on commit 01da692

Please sign in to comment.