Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(schemas): update schemas (DSP-1902) #92

Merged
merged 11 commits into from Sep 20, 2021
Merged

chore(schemas): update schemas (DSP-1902) #92

merged 11 commits into from Sep 20, 2021

Conversation

irinaschubert
Copy link

resolves DSP-1902

@irinaschubert irinaschubert marked this pull request as ready for review September 15, 2021 10:03
@irinaschubert irinaschubert self-assigned this Sep 15, 2021
BalduinLandolt
BalduinLandolt approved these changes Sep 16, 2021
View reviewed changes
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

Just remember that all ontology json files that don't have the schema added, will now fail validation. That will require some adjusting here and there, I suppose. But I'm not sure where...

knora/dsplib/schemas/data.xsd Show resolved Hide resolved
@irinaschubert irinaschubert merged commit 16ba335 into main Sep 20, 2021
@irinaschubert irinaschubert deleted the wip/dsp-1902-update-schemas branch September 20, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

Assignees

@irinaschubert irinaschubert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@irinaschubert @BalduinLandolt