chore: automate release process (DSP-1492) #52
Conversation
|
crazy shit! I'll take a look |
.github/workflows/release-please.yml
Outdated
| with: | ||
| token: ${{ secrets.GH_TOKEN }} | ||
| release-type: python | ||
| package-name: gh_action_test |
There was a problem hiding this comment.
Package name is maybe wrong here. This name will be used as prefix in the release
There was a problem hiding this comment.
oh, yes, missed that, thanks
|
I divided it into different files in hope the "separation of concerns" would make it simpler... Also, should I add automated notification too? |
No problem. That's fine.
Yes, if you like. Why not? |
It just poses the question, to what extent it should be unified all over the other repos. And if so, how it should be done everywhere.
Done. I hope this will work like this, haven't tested that beforehand. |
.github/workflows/ckeck-pr-title.yml
Outdated
| # check PR title | ||
| - uses: deepakputhraya/action-pr-title@master | ||
| with: | ||
| regex: '([a-z])+(\(([a-z\-_])+\))?!?: ([a-z])+' # Regex the title should match. |
There was a problem hiding this comment.
Would it make sense to add something like \(DSP-\d+\) to the end of the regex?
By convention, the PR's title should end with "(DSP-123)".
It's is actually missing from this PR's title :-)
There was a problem hiding this comment.
Not all PRs have a task on youtrack. So, this can be tricky. And for example, in another repo I had a task of type PM- and not DSP-.
There was a problem hiding this comment.
You're right that it's missing here in the PR title... ;-)
But I also think it might become at some point problematic to enforce it. (There are also some tasks with BS-123. I'm not sure this will be the case in the future, so I think it's a bit risky to enforce this strictly.)
There was a problem hiding this comment.
maybe make it more general: expect something like: \(.+-\d+\)
There was a problem hiding this comment.
however, I leave this up to you
There was a problem hiding this comment.
I went even stricter: \([A-Z]+-\d+\)
Do you think it's a problem that I allow only lower case letters in the PR title? Should probably be extended to upper case too, right? (e.g. for abbreviations that often use upper case.)
There was a problem hiding this comment.
I went even stricter:
\([A-Z]+-\d+\)
you are reading my thoughts :-)
Do you think it's a problem that I allow only lower case letters in the PR title? Should probably be extended to upper case too, right? (e.g. for abbreviations that often use upper case.)
no idea
There was a problem hiding this comment.
I'll just add upper case, just to be sure
There was a problem hiding this comment.
you can never be too paranoid
There was a problem hiding this comment.
we could argue about that ;-)
BalduinLandolt
changed the title
Resolves: DSP-1492
Questions:
pythonorpython3, andpip/pip3respectively?