feat: import lists from excel (DSP-1341) #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # knora/dsplib/models/connection.py
# Conflicts: # knora/bitstreams/test.csv # knora/dsp_tools.py # knora/test-onto.json
subotic
changed the title
|
@lrosenth please add |
BalduinLandolt
requested changes
Feb 16, 2021
There was a problem hiding this comment.
See my review comments.
Also note the following things I could not comment directly into the files:
- please add
.DS_Storeto.gitignore - please ensure not to include any sensitive data in CSVs
- be sure not to include any copyright protected files as test data (I haven't checked images and audio, but PDF is an NZZ article which is not public domain)
subotic
requested changes
Feb 16, 2021
BalduinLandolt
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for hierarchical lists in excel files and updated the documentation to make it more consistent and a bit easier to navigate.